A fork of Gitea (see branch `mj`) adding Majority Judgment Polls 𐄷 over Issues and Merge Requests. https://git.mieuxvoter.fr
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

103 lines
3.5 KiB

Use native git variants by default with go-git variants as build tag (#13673) * Move last commit cache back into modules/git Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove go-git from the interface for last commit cache Signed-off-by: Andrew Thornton <art27@cantab.net> * move cacheref to last_commit_cache Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove go-git from routers/private/hook Signed-off-by: Andrew Thornton <art27@cantab.net> * Move FindLFSFiles to pipeline Signed-off-by: Andrew Thornton <art27@cantab.net> * Make no-go-git variants Signed-off-by: Andrew Thornton <art27@cantab.net> * Submodule RefID Signed-off-by: Andrew Thornton <art27@cantab.net> * fix issue with GetCommitsInfo Signed-off-by: Andrew Thornton <art27@cantab.net> * fix GetLastCommitForPaths Signed-off-by: Andrew Thornton <art27@cantab.net> * Improve efficiency Signed-off-by: Andrew Thornton <art27@cantab.net> * More efficiency Signed-off-by: Andrew Thornton <art27@cantab.net> * even faster Signed-off-by: Andrew Thornton <art27@cantab.net> * Reduce duplication * As per @lunny Signed-off-by: Andrew Thornton <art27@cantab.net> * attempt to fix drone Signed-off-by: Andrew Thornton <art27@cantab.net> * fix test-tags Signed-off-by: Andrew Thornton <art27@cantab.net> * default to use no-go-git variants and add gogit build tag Signed-off-by: Andrew Thornton <art27@cantab.net> * placate lint Signed-off-by: Andrew Thornton <art27@cantab.net> * as per @6543 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2 years ago
Improve listing performance by using go-git (#6478) * Use go-git for tree reading and commit info lookup. Signed-off-by: Filip Navara <navara@emclient.com> * Use TreeEntry.IsRegular() instead of ObjectType that was removed. Signed-off-by: Filip Navara <navara@emclient.com> * Use the treePath to optimize commit info search. Signed-off-by: Filip Navara <navara@emclient.com> * Extract the latest commit at treePath along with the other commits. Signed-off-by: Filip Navara <navara@emclient.com> * Fix listing commit info for a directory that was created in one commit and never modified after. Signed-off-by: Filip Navara <navara@emclient.com> * Avoid nearly all external 'git' invocations when doing directory listing (.editorconfig code path is still hit). Signed-off-by: Filip Navara <navara@emclient.com> * Use go-git for reading blobs. Signed-off-by: Filip Navara <navara@emclient.com> * Make SHA1 type alias for plumbing.Hash in go-git. Signed-off-by: Filip Navara <navara@emclient.com> * Make Signature type alias for object.Signature in go-git. Signed-off-by: Filip Navara <navara@emclient.com> * Fix GetCommitsInfo for repository with only one commit. Signed-off-by: Filip Navara <navara@emclient.com> * Fix PGP signature verification. Signed-off-by: Filip Navara <navara@emclient.com> * Fix issues with walking commit graph across merges. Signed-off-by: Filip Navara <navara@emclient.com> * Fix typo in condition. Signed-off-by: Filip Navara <navara@emclient.com> * Speed up loading branch list by keeping the repository reference (and thus all the loaded packfile indexes). Signed-off-by: Filip Navara <navara@emclient.com> * Fix lising submodules. Signed-off-by: Filip Navara <navara@emclient.com> * Fix build Signed-off-by: Filip Navara <navara@emclient.com> * Add back commit cache because of name-rev Signed-off-by: Filip Navara <navara@emclient.com> * Fix tests Signed-off-by: Filip Navara <navara@emclient.com> * Fix code style * Fix spelling * Address PR feedback Signed-off-by: Filip Navara <navara@emclient.com> * Update vendor module list Signed-off-by: Filip Navara <navara@emclient.com> * Fix getting trees by commit id Signed-off-by: Filip Navara <navara@emclient.com> * Fix remaining unit test failures * Fix GetTreeBySHA * Avoid running `git name-rev` if not necessary Signed-off-by: Filip Navara <navara@emclient.com> * Move Branch code to git module * Clean up GPG signature verification and fix it for tagged commits * Address PR feedback (import formatting, copyright headers) * Make blob lookup by SHA working * Update tests to use public API * Allow getting content from any type of object through the blob interface * Change test to actually expect the object content that is in the GIT repository * Change one more test to actually expect the object content that is in the GIT repository * Add comments
4 years ago
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. // +build gogit
  5. package git
  6. import (
  7. "testing"
  8. "github.com/go-git/go-git/v5/plumbing/filemode"
  9. "github.com/go-git/go-git/v5/plumbing/object"
  10. "github.com/stretchr/testify/assert"
  11. )
  12. func getTestEntries() Entries {
  13. return Entries{
  14. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v1.0", Mode: filemode.Dir}},
  15. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v2.0", Mode: filemode.Dir}},
  16. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v2.1", Mode: filemode.Dir}},
  17. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v2.12", Mode: filemode.Dir}},
  18. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v2.2", Mode: filemode.Dir}},
  19. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "v12.0", Mode: filemode.Dir}},
  20. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "abc", Mode: filemode.Regular}},
  21. &TreeEntry{gogitTreeEntry: &object.TreeEntry{Name: "bcd", Mode: filemode.Regular}},
  22. }
  23. }
  24. func TestEntriesSort(t *testing.T) {
  25. entries := getTestEntries()
  26. entries.Sort()
  27. assert.Equal(t, "v1.0", entries[0].Name())
  28. assert.Equal(t, "v12.0", entries[1].Name())
  29. assert.Equal(t, "v2.0", entries[2].Name())
  30. assert.Equal(t, "v2.1", entries[3].Name())
  31. assert.Equal(t, "v2.12", entries[4].Name())
  32. assert.Equal(t, "v2.2", entries[5].Name())
  33. assert.Equal(t, "abc", entries[6].Name())
  34. assert.Equal(t, "bcd", entries[7].Name())
  35. }
  36. func TestEntriesCustomSort(t *testing.T) {
  37. entries := getTestEntries()
  38. entries.CustomSort(func(s1, s2 string) bool {
  39. return s1 > s2
  40. })
  41. assert.Equal(t, "v2.2", entries[0].Name())
  42. assert.Equal(t, "v2.12", entries[1].Name())
  43. assert.Equal(t, "v2.1", entries[2].Name())
  44. assert.Equal(t, "v2.0", entries[3].Name())
  45. assert.Equal(t, "v12.0", entries[4].Name())
  46. assert.Equal(t, "v1.0", entries[5].Name())
  47. assert.Equal(t, "bcd", entries[6].Name())
  48. assert.Equal(t, "abc", entries[7].Name())
  49. }
  50. func TestFollowLink(t *testing.T) {
  51. r, err := OpenRepository("tests/repos/repo1_bare")
  52. assert.NoError(t, err)
  53. defer r.Close()
  54. commit, err := r.GetCommit("37991dec2c8e592043f47155ce4808d4580f9123")
  55. assert.NoError(t, err)
  56. // get the symlink
  57. lnk, err := commit.Tree.GetTreeEntryByPath("foo/bar/link_to_hello")
  58. assert.NoError(t, err)
  59. assert.True(t, lnk.IsLink())
  60. // should be able to dereference to target
  61. target, err := lnk.FollowLink()
  62. assert.NoError(t, err)
  63. assert.Equal(t, target.Name(), "hello")
  64. assert.False(t, target.IsLink())
  65. assert.Equal(t, target.ID.String(), "b14df6442ea5a1b382985a6549b85d435376c351")
  66. // should error when called on normal file
  67. target, err = commit.Tree.GetTreeEntryByPath("file1.txt")
  68. assert.NoError(t, err)
  69. _, err = target.FollowLink()
  70. assert.Equal(t, err.Error(), "file1.txt: not a symlink")
  71. // should error for broken links
  72. target, err = commit.Tree.GetTreeEntryByPath("foo/broken_link")
  73. assert.NoError(t, err)
  74. assert.True(t, target.IsLink())
  75. _, err = target.FollowLink()
  76. assert.Equal(t, err.Error(), "broken_link: broken link")
  77. // should error for external links
  78. target, err = commit.Tree.GetTreeEntryByPath("foo/outside_repo")
  79. assert.NoError(t, err)
  80. assert.True(t, target.IsLink())
  81. _, err = target.FollowLink()
  82. assert.Equal(t, err.Error(), "outside_repo: points outside of repo")
  83. // testing fix for short link bug
  84. target, err = commit.Tree.GetTreeEntryByPath("foo/link_short")
  85. assert.NoError(t, err)
  86. _, err = target.FollowLink()
  87. assert.Equal(t, err.Error(), "link_short: broken link")
  88. }