From 0b3a9c4f851fe7302bbbab91721fd2e641a4ed22 Mon Sep 17 00:00:00 2001 From: zeripath Date: Tue, 3 Mar 2020 20:57:27 +0000 Subject: [PATCH] Fix LFS max file size enforcement (#10593) Unfortunately the batch handler also needs to enforce max file size. Enforce max file size in batch handler --- modules/lfs/server.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/modules/lfs/server.go b/modules/lfs/server.go index d6798ec4f..5899f4dfc 100644 --- a/modules/lfs/server.go +++ b/modules/lfs/server.go @@ -307,6 +307,12 @@ func BatchHandler(ctx *context.Context) { continue } + if requireWrite && setting.LFS.MaxFileSize > 0 && object.Size > setting.LFS.MaxFileSize { + log.Info("Denied LFS upload of size %d to %s/%s because of LFS_MAX_FILE_SIZE=%d", object.Size, object.User, object.Repo, setting.LFS.MaxFileSize) + writeStatus(ctx, 413) + return + } + // Object is not found meta, err = models.NewLFSMetaObject(&models.LFSMetaObject{Oid: object.Oid, Size: object.Size, RepositoryID: repository.ID}) if err == nil {