From 0c2cbfcb3ba5ac743e7a6b5a8d781d554448b07e Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 16 May 2021 14:42:12 +0100 Subject: [PATCH] Move sans-serif fallback font higher than emoji fonts (#15855) (#15892) Backport #15855 The Tor browser does not use the system-ui font and no other fonts in the stack match its default fonts. In fact it is possible that it will in future only match generic fonts. This means that all rendering will first try the emoji fonts before falling back to the sans-serif font for glyphs. In this case has the emoji fall back fonts for Tor contains empty glyphs for numbers - in order to protect privacy - and leads to numbers being rendered as empty glyphs. This is clearly not ideal and whilst we could use the Arimo font - as I state above I suspect that Tor will eventually ban detecting this and we should instead move the sans-serif font higher in the stack so that it matches before the emoji fonts. Partial fix of #15844 Signed-off-by: Andrew Thornton --- web_src/less/_base.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_src/less/_base.less b/web_src/less/_base.less index 07f3c59f8..a59f5a58d 100644 --- a/web_src/less/_base.less +++ b/web_src/less/_base.less @@ -118,7 +118,7 @@ } :root * { - --fonts-regular: var(--fonts-override, var(--fonts-proportional)), "Noto Sans", "Liberation Sans", var(--fonts-emoji), sans-serif; + --fonts-regular: var(--fonts-override, var(--fonts-proportional)), "Noto Sans", "Liberation Sans", sans-serif, var(--fonts-emoji); } textarea {