From 1bf40ca0df431afdca1b3a3836a57914401205d3 Mon Sep 17 00:00:00 2001 From: zeripath Date: Wed, 7 Oct 2020 21:44:16 +0100 Subject: [PATCH] Gitea serv, hooks, manager and the like should always display Fatals (#13032) The gitea cmd/serv.go setup function deletes the console logger to prevent stdout interference with commands. However, the problem is that it then calls setting.NewContext which may cause an exit with log.Fatal - which will then not be shown. Now, log.Fatal is so disastrous that the interference that logging causes is wanted. However, we can avoid stdout interference by emitting on stderr. This PR forces the creation of a console logger on stderr listening on Fatal for these commands. Most commands have a `--debug` option now that will print more reasons too - however, defaulting to give the log for Fatal seems reasonable. Signed-off-by: Andrew Thornton --- cmd/serv.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/serv.go b/cmd/serv.go index b6cdab833..193838800 100644 --- a/cmd/serv.go +++ b/cmd/serv.go @@ -54,6 +54,8 @@ func setup(logPath string, debug bool) { _ = log.DelLogger("console") if debug { _ = log.NewLogger(1000, "console", "console", `{"level":"trace","stacktracelevel":"NONE","stderr":true}`) + } else { + _ = log.NewLogger(1000, "console", "console", `{"level":"fatal","stacktracelevel":"NONE","stderr":true}`) } setting.NewContext() if debug {