From 1f877f8c875891d3647c9a6413abc02aa5787109 Mon Sep 17 00:00:00 2001 From: Bwko Date: Mon, 4 Jun 2018 07:34:44 +0200 Subject: [PATCH] Add tag check to release draft creation (#3729) --- modules/auth/repo_form.go | 2 +- modules/validation/binding.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/auth/repo_form.go b/modules/auth/repo_form.go index e3471fff5..4ea1ba90e 100644 --- a/modules/auth/repo_form.go +++ b/modules/auth/repo_form.go @@ -371,7 +371,7 @@ func (f *MergePullRequestForm) Validate(ctx *macaron.Context, errs binding.Error // NewReleaseForm form for creating release type NewReleaseForm struct { - TagName string `binding:"Required"` + TagName string `binding:"Required;GitRefName"` Target string `form:"tag_target" binding:"Required"` Title string `binding:"Required"` Content string diff --git a/modules/validation/binding.go b/modules/validation/binding.go index 3f671890b..7aaed59c1 100644 --- a/modules/validation/binding.go +++ b/modules/validation/binding.go @@ -19,7 +19,7 @@ const ( ) var ( - // GitRefNamePattern is regular expression wirh unallowed characters in git reference name + // GitRefNamePattern is regular expression with unallowed characters in git reference name GitRefNamePattern = regexp.MustCompile("[^\\d\\w-_\\./]") )