From 20c54f88b23bbf56ac3cc3a74baeed98d7ab0844 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Mon, 3 Dec 2018 22:28:46 +0800 Subject: [PATCH] refactor: replace lint to revive (#5422) * refactor: replace lint to revive * make changes. Signed-off-by: Bo-Yi Wu --- .revive.toml | 25 +++++++++++++++++++++++++ Makefile | 6 +++--- 2 files changed, 28 insertions(+), 3 deletions(-) create mode 100644 .revive.toml diff --git a/.revive.toml b/.revive.toml new file mode 100644 index 000000000..74743d5ef --- /dev/null +++ b/.revive.toml @@ -0,0 +1,25 @@ +ignoreGeneratedHeader = false +severity = "warning" +confidence = 0.8 +errorCode = 1 +warningCode = 1 + +[rule.blank-imports] +[rule.context-as-argument] +[rule.context-keys-type] +[rule.dot-imports] +[rule.error-return] +[rule.error-strings] +[rule.error-naming] +[rule.exported] +[rule.if-return] +[rule.increment-decrement] +[rule.var-naming] +[rule.var-declaration] +[rule.package-comments] +[rule.range] +[rule.receiver-naming] +[rule.time-naming] +[rule.unexported-return] +[rule.indent-error-flow] +[rule.errorf] diff --git a/Makefile b/Makefile index 5e7e72df0..f007665e7 100644 --- a/Makefile +++ b/Makefile @@ -128,10 +128,10 @@ errcheck: .PHONY: lint lint: - @hash golint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - $(GO) get -u golang.org/x/lint/golint; \ + @hash revive > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ + $(GO) get -u github.com/mgechev/revive; \ fi - for PKG in $(PACKAGES); do golint -set_exit_status $$PKG || exit 1; done; + revive -config .revive.toml -exclude=./vendor/... ./... || exit 1 .PHONY: misspell-check misspell-check: