From 23f072887935a6aa81634ef487432ff2b5fa250a Mon Sep 17 00:00:00 2001
From: Ethan Koenig <ethantkoenig@gmail.com>
Date: Thu, 29 Jun 2017 10:30:58 -0400
Subject: [PATCH] Don't ignore gravatar error

---
 modules/base/tool.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/modules/base/tool.go b/modules/base/tool.go
index 8952e7a8c..0f730868e 100644
--- a/modules/base/tool.go
+++ b/modules/base/tool.go
@@ -197,8 +197,10 @@ func HashEmail(email string) string {
 // to return full URL if user enables Gravatar-like service.
 func AvatarLink(email string) string {
 	if setting.EnableFederatedAvatar && setting.LibravatarService != nil {
-		// TODO: This doesn't check any error. AvatarLink should return (string, error)
-		url, _ := setting.LibravatarService.FromEmail(email)
+		url, err := setting.LibravatarService.FromEmail(email)
+		if err != nil {
+			log.Error(4, "LibravatarService.FromEmail(email=%s): error %v", email, err)
+		}
 		return url
 	}