Browse Source

Missed defer prepareTestEnv (#9285)

* onGiteaRun should defer the cleanup from prepareTestEnv

* Some more missed defers
lunny/display_deleted_branch2
zeripath 3 years ago
committed by GitHub
parent
commit
3da6d256f4
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      integrations/benchmarks_test.go
  2. 2
      integrations/git_helper_for_declarative_test.go
  3. 2
      integrations/gpg_git_test.go

4
integrations/benchmarks_test.go

@ -25,7 +25,7 @@ func BenchmarkRepo(b *testing.B) {
{url: "https://github.com/golang/go.git", name: "go", skipShort: true},
{url: "https://github.com/torvalds/linux.git", name: "linux", skipShort: true},
}
prepareTestEnv(b)
defer prepareTestEnv(b)()
session := loginUser(b, "user2")
b.ResetTimer()
@ -75,7 +75,7 @@ func StringWithCharset(length int, charset string) string {
func BenchmarkRepoBranchCommit(b *testing.B) {
samples := []int64{1, 3, 15, 16}
prepareTestEnv(b)
defer prepareTestEnv(b)()
b.ResetTimer()
for _, repoID := range samples {

2
integrations/git_helper_for_declarative_test.go

@ -78,7 +78,7 @@ func allowLFSFilters() []string {
func onGiteaRun(t *testing.T, callback func(*testing.T, *url.URL), prepare ...bool) {
if len(prepare) == 0 || prepare[0] {
prepareTestEnv(t, 1)
defer prepareTestEnv(t, 1)()
}
s := http.Server{
Handler: mac,

2
integrations/gpg_git_test.go

@ -23,7 +23,7 @@ import (
)
func TestGPGGit(t *testing.T) {
prepareTestEnv(t)
defer prepareTestEnv(t)()
username := "user2"
// OK Set a new GPG home

Loading…
Cancel
Save