From 5e4e7d3df023892aa053d7c3e3005ab5f440b2e5 Mon Sep 17 00:00:00 2001
From: Christian Muehlhaeuser <muesli@gmail.com>
Date: Tue, 23 Jul 2019 21:28:43 +0200
Subject: [PATCH] Added missing error checks in tests (#7554)

Whenever we assign a value to err, check for it being nil.
---
 models/release_test.go          | 2 ++
 models/repo_test.go             | 1 +
 modules/git/repo_commit_test.go | 5 ++++-
 modules/git/repo_stats_test.go  | 1 +
 4 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/models/release_test.go b/models/release_test.go
index 83c3fe2f7..6da3cd762 100644
--- a/models/release_test.go
+++ b/models/release_test.go
@@ -139,6 +139,7 @@ func TestRelease_MirrorDelete(t *testing.T) {
 	assert.True(t, ok)
 
 	count, err := GetReleaseCountByRepoID(mirror.ID, findOptions)
+	assert.NoError(t, err)
 	assert.EqualValues(t, initCount+1, count)
 
 	release, err := GetRelease(repo.ID, "v0.2")
@@ -149,5 +150,6 @@ func TestRelease_MirrorDelete(t *testing.T) {
 	assert.True(t, ok)
 
 	count, err = GetReleaseCountByRepoID(mirror.ID, findOptions)
+	assert.NoError(t, err)
 	assert.EqualValues(t, initCount, count)
 }
diff --git a/models/repo_test.go b/models/repo_test.go
index 02cb5ab99..8c3f14695 100644
--- a/models/repo_test.go
+++ b/models/repo_test.go
@@ -88,6 +88,7 @@ func TestUpdateRepositoryVisibilityChanged(t *testing.T) {
 
 	// Get sample repo and change visibility
 	repo, err := GetRepositoryByID(9)
+	assert.NoError(t, err)
 	repo.IsPrivate = true
 
 	// Update it
diff --git a/modules/git/repo_commit_test.go b/modules/git/repo_commit_test.go
index 6761a45b7..c0fdd1697 100644
--- a/modules/git/repo_commit_test.go
+++ b/modules/git/repo_commit_test.go
@@ -40,8 +40,9 @@ func TestRepository_GetCommitBranches(t *testing.T) {
 func TestGetTagCommitWithSignature(t *testing.T) {
 	bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
 	bareRepo1, err := OpenRepository(bareRepo1Path)
-	commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
+	assert.NoError(t, err)
 
+	commit, err := bareRepo1.GetCommit("3ad28a9149a2864384548f3d17ed7f38014c9e8a")
 	assert.NoError(t, err)
 	assert.NotNil(t, commit)
 	assert.NotNil(t, commit.Signature)
@@ -52,6 +53,8 @@ func TestGetTagCommitWithSignature(t *testing.T) {
 func TestGetCommitWithBadCommitID(t *testing.T) {
 	bareRepo1Path := filepath.Join(testReposDir, "repo1_bare")
 	bareRepo1, err := OpenRepository(bareRepo1Path)
+	assert.NoError(t, err)
+
 	commit, err := bareRepo1.GetCommit("bad_branch")
 	assert.Nil(t, commit)
 	assert.Error(t, err)
diff --git a/modules/git/repo_stats_test.go b/modules/git/repo_stats_test.go
index 1822af0be..6fbcb7ac1 100644
--- a/modules/git/repo_stats_test.go
+++ b/modules/git/repo_stats_test.go
@@ -18,6 +18,7 @@ func TestRepository_GetCodeActivityStats(t *testing.T) {
 	assert.NoError(t, err)
 
 	timeFrom, err := time.Parse(time.RFC3339, "2016-01-01T00:00:00+00:00")
+	assert.NoError(t, err)
 
 	code, err := bareRepo1.GetCodeActivityStats(timeFrom, "")
 	assert.NoError(t, err)