if milestone id is zero don't get it from database (#7169)

5 years ago · 7162fbf3d6
parent d93e6232e8
commit 7162fbf3d6
1 changed files with 8 additions and 6 deletions
--- a/routers/repo/issue.go
+++ b/routers/repo/issue.go
@ -426,12 +426,14 @@ func NewIssue(ctx *context.Context) {
 	ctx.Data["BodyQuery"] = body

 	milestoneID := ctx.QueryInt64("milestone")
-	milestone, err := models.GetMilestoneByID(milestoneID)
-	if err != nil {
-		log.Error("GetMilestoneByID: %d: %v", milestoneID, err)
-	} else {
-		ctx.Data["milestone_id"] = milestoneID
-		ctx.Data["Milestone"] = milestone
+	if milestoneID > 0 {
+		milestone, err := models.GetMilestoneByID(milestoneID)
+		if err != nil {
+			log.Error("GetMilestoneByID: %d: %v", milestoneID, err)
+		} else {
+			ctx.Data["milestone_id"] = milestoneID
+			ctx.Data["Milestone"] = milestone
+		}
 	}

 	setTemplateIfExists(ctx, issueTemplateKey, IssueTemplateCandidates)