Prevent xorm nil insert in Review.Comments (#11150)

4 years ago · 77171abcad
parent e37e217602
commit 77171abcad
1 changed files with 4 additions and 2 deletions
--- a/models/review.go
+++ b/models/review.go
@ -457,8 +457,10 @@ func InsertReviews(reviews []*Review) error {
 			c.ReviewID = review.ID
 		}

-		if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
-			return err
+		if len(review.Comments) > 0 {
+			if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
+				return err
+			}
 		}
 	}