From 87404d7c0b0ff42be73398c86f5356959dc7b632 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 7 Jul 2019 11:00:41 +0800 Subject: [PATCH] Use vendors when go generate (#7340) * use vendors when go generate * update docs about golang minimal requirement from 1.9 to 1.11 * fix build --- .drone.yml | 6 ++++-- Makefile | 2 +- docs/content/doc/advanced/hacking-on-gitea.en-us.md | 2 +- docs/content/doc/installation/from-source.en-us.md | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.drone.yml b/.drone.yml index 9c0759994..086b5cd2b 100644 --- a/.drone.yml +++ b/.drone.yml @@ -63,9 +63,11 @@ steps: - name: build-without-gcc pull: always - image: golang:1.10 # this step is kept as the lowest version of golang that we support + image: golang:1.11 # this step is kept as the lowest version of golang that we support + environment: + GO111MODULE: on commands: - - go build -o gitea_no_gcc # test if build succeeds without the sqlite tag + - go build -mod=vendor -o gitea_no_gcc # test if build succeeds without the sqlite tag - name: build pull: always diff --git a/Makefile b/Makefile index 796a0e3b5..2c6a6ef72 100644 --- a/Makefile +++ b/Makefile @@ -97,7 +97,7 @@ vet: .PHONY: generate generate: - GO111MODULE=on $(GO) generate $(PACKAGES) + GO111MODULE=on $(GO) generate -mod=vendor $(PACKAGES) .PHONY: generate-swagger generate-swagger: diff --git a/docs/content/doc/advanced/hacking-on-gitea.en-us.md b/docs/content/doc/advanced/hacking-on-gitea.en-us.md index d04cdfca5..ef29051e7 100644 --- a/docs/content/doc/advanced/hacking-on-gitea.en-us.md +++ b/docs/content/doc/advanced/hacking-on-gitea.en-us.md @@ -32,7 +32,7 @@ necessary. To be able to use these you must have the `"$GOPATH"/bin` directory on the executable path. If you don't add the go bin directory to the executable path you will have to manage this yourself. -**Note 2**: Go version 1.9 or higher is required; however, it is important +**Note 2**: Go version 1.11 or higher is required; however, it is important to note that our continuous integration will check that the formatting of the source code is not changed by `gofmt` using `make fmt-check`. Unfortunately, the results of `gofmt` can differ by the version of `go`. It is therefore diff --git a/docs/content/doc/installation/from-source.en-us.md b/docs/content/doc/installation/from-source.en-us.md index ce5915cc3..cf6d42802 100644 --- a/docs/content/doc/installation/from-source.en-us.md +++ b/docs/content/doc/installation/from-source.en-us.md @@ -27,7 +27,7 @@ necessary. To be able to use these, you must have the `"$GOPATH/bin"` directory on the executable path. If you don't add the go bin directory to the executable path, you will have to manage this yourself. -**Note 2**: Go version 1.9 or higher is required. However, it is recommended to +**Note 2**: Go version 1.11 or higher is required. However, it is recommended to obtain the same version as our continuous integration, see the advice given in Hacking on Gitea