From 9224405155322e096e7f2d0f9eed35633b937951 Mon Sep 17 00:00:00 2001 From: Fabian Zaremba Date: Wed, 22 Mar 2017 11:43:28 +0100 Subject: [PATCH] LFS: Fix SSH authentication for trailing arguments (#1328) Fixes #1296 --- cmd/serv.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cmd/serv.go b/cmd/serv.go index d9d32217c..dc8952abe 100644 --- a/cmd/serv.go +++ b/cmd/serv.go @@ -123,8 +123,8 @@ func runServ(c *cli.Context) error { fail("Unknown git command", "LFS authentication request over SSH denied, LFS support is disabled") } - if strings.Contains(args, " ") { - argsSplit := strings.SplitN(args, " ", 2) + argsSplit := strings.Split(args, " ") + if len(argsSplit) >= 2 { args = strings.TrimSpace(argsSplit[0]) lfsVerb = strings.TrimSpace(argsSplit[1]) } @@ -179,8 +179,10 @@ func runServ(c *cli.Context) error { if verb == lfsAuthenticateVerb { if lfsVerb == "upload" { requestedMode = models.AccessModeWrite - } else { + } else if lfsVerb == "download" { requestedMode = models.AccessModeRead + } else { + fail("Unknown LFS verb", "Unkown lfs verb %s", lfsVerb) } }