From 946eb1321c620f7fc8938df130809c0522c93613 Mon Sep 17 00:00:00 2001 From: zeripath Date: Wed, 16 Jun 2021 10:06:27 +0100 Subject: [PATCH] Only check access tokens if they are likely to be tokens (#16164) (#16171) Backprt #16164 Gitea will currently check every if every password is an access token even though most passwords are not and cannot be access tokens. By creation access tokens are 40 byte hexadecimal strings therefore only these should be checked. Signed-off-by: Andrew Thornton --- models/token.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/models/token.go b/models/token.go index 1245098df..49541b122 100644 --- a/models/token.go +++ b/models/token.go @@ -57,9 +57,15 @@ func GetAccessTokenBySHA(token string) (*AccessToken, error) { if token == "" { return nil, ErrAccessTokenEmpty{} } - if len(token) < 8 { + // A token is defined as being SHA1 sum these are 40 hexadecimal bytes long + if len(token) != 40 { return nil, ErrAccessTokenNotExist{token} } + for _, x := range []byte(token) { + if x < '0' || (x > '9' && x < 'a') || x > 'f' { + return nil, ErrAccessTokenNotExist{token} + } + } var tokens []AccessToken lastEight := token[len(token)-8:] err := x.Table(&AccessToken{}).Where("token_last_eight = ?", lastEight).Find(&tokens)