From a0d35fb6ad5ac380abd80ac5177234338e2fe2ff Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 17 May 2020 07:05:11 +0100 Subject: [PATCH] Forcibly clean and destroy the session on logout (#11447) Signed-off-by: Andrew Thornton Co-authored-by: techknowlogick --- routers/user/auth.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/routers/user/auth.go b/routers/user/auth.go index 4f01062e3..f00f349a0 100644 --- a/routers/user/auth.go +++ b/routers/user/auth.go @@ -994,11 +994,8 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au // HandleSignOut resets the session and sets the cookies func HandleSignOut(ctx *context.Context) { - _ = ctx.Session.Delete("uid") - _ = ctx.Session.Delete("uname") - _ = ctx.Session.Delete("socialId") - _ = ctx.Session.Delete("socialName") - _ = ctx.Session.Delete("socialEmail") + _ = ctx.Session.Flush() + _ = ctx.Session.Destroy(ctx.Context) ctx.SetCookie(setting.CookieUserName, "", -1, setting.AppSubURL, setting.SessionConfig.Domain, setting.SessionConfig.Secure, true) ctx.SetCookie(setting.CookieRememberName, "", -1, setting.AppSubURL, setting.SessionConfig.Domain, setting.SessionConfig.Secure, true) ctx.SetCookie(setting.CSRFCookieName, "", -1, setting.AppSubURL, setting.SessionConfig.Domain, setting.SessionConfig.Secure, true)