Browse Source

Fix invalid reference in feeds template (#1820)

* Fix invalid reference in feeds template

* Comment for GetActAvatar

* Add integration test
release/v1.2
Ethan Koenig 6 years ago
committed by Lunny Xiao
parent
commit
bafd778c25
  1. 9
      integrations/issue_test.go
  2. 6
      models/action.go
  3. 2
      templates/user/dashboard/feeds.tmpl

9
integrations/issue_test.go

@ -11,6 +11,15 @@ import (
"github.com/stretchr/testify/assert"
)
func TestNoLoginViewIssues(t *testing.T) {
prepareTestEnv(t)
req, err := http.NewRequest("GET", "/user2/repo1/issues", nil)
assert.NoError(t, err)
resp := MakeRequest(req)
assert.EqualValues(t, http.StatusOK, resp.HeaderCode)
}
func TestNoLoginViewIssue(t *testing.T) {
prepareTestEnv(t)

6
models/action.go

@ -142,6 +142,12 @@ func (a *Action) ShortActUserName() string {
return base.EllipsisString(a.GetActUserName(), 20)
}
// GetActAvatar the action's user's avatar link
func (a *Action) GetActAvatar() string {
a.loadActUser()
return a.ActUser.AvatarLink()
}
// GetRepoUserName returns the name of the action repository owner.
func (a *Action) GetRepoUserName() string {
a.loadRepo()

2
templates/user/dashboard/feeds.tmpl

@ -1,7 +1,7 @@
{{range .Feeds}}
<div class="news">
<div class="ui left">
<img class="ui avatar image" src="{{.ActAvatar}}" alt="">
<img class="ui avatar image" src="{{.GetActAvatar}}" alt="">
</div>
<div class="ui grid">
<div class="ui fifteen wide column">

Loading…
Cancel
Save