From e0ac545043d81c9096c161e127a9d4d9e88b1d9f Mon Sep 17 00:00:00 2001 From: zeripath Date: Fri, 11 Sep 2020 10:30:19 +0100 Subject: [PATCH] Add postgres schema to the search_path on database connection (#12634) Rather than rely on the user running the gitea server and db setting the schema search_path correctly - if gitea is run with a schema we should simply set the search_path to have that schema first in the path. Fix #12505 Signed-off-by: Andrew Thornton --- integrations/integration_test.go | 10 ---------- models/models.go | 10 ++++++++++ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/integrations/integration_test.go b/integrations/integration_test.go index 36e068209..3942d5441 100644 --- a/integrations/integration_test.go +++ b/integrations/integration_test.go @@ -198,16 +198,6 @@ func initIntegrationTest() { } } - // Make the user's default search path the created schema; this will affect new connections - if _, err = db.Exec(fmt.Sprintf(`ALTER USER "%s" SET search_path = %s`, setting.Database.User, setting.Database.Schema)); err != nil { - log.Fatalf("db.Exec: ALTER USER SET search_path: %v", err) - } - - // Make the current connection's search the created schema - if _, err = db.Exec(fmt.Sprintf(`SET search_path = %s`, setting.Database.Schema)); err != nil { - log.Fatalf("db.Exec: ALTER USER SET search_path: %v", err) - } - case setting.Database.UseMSSQL: host, port := setting.ParseMSSQLHostPort(setting.Database.Host) db, err := sql.Open("mssql", fmt.Sprintf("server=%s; port=%s; database=%s; user id=%s; password=%s;", diff --git a/models/models.go b/models/models.go index 32df9bdfd..6aaa26d62 100644 --- a/models/models.go +++ b/models/models.go @@ -155,6 +155,16 @@ func getEngine() (*xorm.Engine, error) { engine.Dialect().SetParams(map[string]string{"DEFAULT_VARCHAR": "nvarchar"}) } engine.SetSchema(setting.Database.Schema) + if setting.Database.UsePostgreSQL && len(setting.Database.Schema) > 0 { + // Add the schema to the search path + if _, err := engine.Exec(`SELECT set_config( + 'search_path', + ? || ',' || current_setting('search_path'), + false)`, + setting.Database.Schema); err != nil { + return nil, err + } + } return engine, nil }