From e65cfabda7caa22eef92137c5c501d1c60fcc42a Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 7 Feb 2021 21:04:58 +0000 Subject: [PATCH] Remove spurious DataAsync Error logging (#14599) Breaking the pipe is a valid way of killing a piped command and any error from a broken cat-file batch command should be passed back up to the writer any way therefore specifically logging it is unnecessary. Signed-off-by: Andrew Thornton --- modules/git/blob_nogogit.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/modules/git/blob_nogogit.go b/modules/git/blob_nogogit.go index 731f7d06e..e917a3161 100644 --- a/modules/git/blob_nogogit.go +++ b/modules/git/blob_nogogit.go @@ -11,8 +11,6 @@ import ( "io" "strconv" "strings" - - gitea_log "code.gitea.io/gitea/modules/log" ) // Blob represents a Git object. @@ -35,7 +33,6 @@ func (b *Blob) DataAsync() (io.ReadCloser, error) { err := NewCommand("cat-file", "--batch").RunInDirFullPipeline(b.repoPath, stdoutWriter, stderr, strings.NewReader(b.ID.String()+"\n")) if err != nil { err = ConcatenateError(err, stderr.String()) - gitea_log.Error("Blob.DataAsync Error: %v", err) _ = stdoutWriter.CloseWithError(err) } else { _ = stdoutWriter.Close()