Browse Source
Fixed issues not updated by commits (#16254)
`UpdateIssuesCommit` may get called with fewer commits because of `FeedMaxCommitNum` and therefore may miss some commands.
master
KN4CK3R
1 year ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with
5 additions and
4 deletions
-
services/repository/push.go
|
|
@ -193,16 +193,17 @@ func pushUpdates(optsList []*repo_module.PushUpdateOptions) error { |
|
|
|
} |
|
|
|
|
|
|
|
commits = repo_module.ListToPushCommits(l) |
|
|
|
|
|
|
|
if err := repofiles.UpdateIssuesCommit(pusher, repo, commits.Commits, refName); err != nil { |
|
|
|
log.Error("updateIssuesCommit: %v", err) |
|
|
|
} |
|
|
|
|
|
|
|
if len(commits.Commits) > setting.UI.FeedMaxCommitNum { |
|
|
|
commits.Commits = commits.Commits[:setting.UI.FeedMaxCommitNum] |
|
|
|
} |
|
|
|
commits.CompareURL = repo.ComposeCompareURL(opts.OldCommitID, opts.NewCommitID) |
|
|
|
notification.NotifyPushCommits(pusher, repo, opts, commits) |
|
|
|
|
|
|
|
if err := repofiles.UpdateIssuesCommit(pusher, repo, commits.Commits, refName); err != nil { |
|
|
|
log.Error("updateIssuesCommit: %v", err) |
|
|
|
} |
|
|
|
|
|
|
|
if err = models.RemoveDeletedBranch(repo.ID, branch); err != nil { |
|
|
|
log.Error("models.RemoveDeletedBranch %s/%s failed: %v", repo.ID, branch, err) |
|
|
|
} |
|
|
|