From e8958bfc38e82148f4c8cecb98f5faed4fd84420 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 6 Sep 2020 18:34:51 +0800 Subject: [PATCH] Fix bug of migraition v111 (#12738) --- models/migrations/v111.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/models/migrations/v111.go b/models/migrations/v111.go index 12eb2d244..93831de94 100644 --- a/models/migrations/v111.go +++ b/models/migrations/v111.go @@ -380,10 +380,10 @@ func addBranchProtectionCanPushAndEnableWhitelist(x *xorm.Engine) error { } totalPages := totalIssues / pageSize - // Find latest review of each user in each pull request, and set official field if appropriate - reviews := []*Review{} - var executeBody = func(page, pageSize int64) error { + // Find latest review of each user in each pull request, and set official field if appropriate + reviews := []*Review{} + if err := x.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id > ? AND issue_id <= ? AND type in (?, ?) GROUP BY issue_id, reviewer_id)", page*pageSize, (page+1)*pageSize, ReviewTypeApprove, ReviewTypeReject). Find(&reviews); err != nil {