Set the initial commit status to Success otherwise it will always be Pending (#10317)

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
4 years ago · e96f3542d0
parent 314740e215
commit e96f3542d0
1 changed files with 1 additions and 1 deletions
--- a/services/pull/commit_status.go
+++ b/services/pull/commit_status.go
@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
 		return structs.CommitStatusSuccess
 	}

-	var returnedStatus = structs.CommitStatusPending
+	var returnedStatus = structs.CommitStatusSuccess
 	for _, ctx := range requiredContexts {
 		var targetStatus structs.CommitStatusState
 		for _, commitStatus := range commitStatuses {