Browse Source
add request review from specific reviewers feature in pull request (#10756)
add request review from specific reviewers feature in pull request (#10756)
* add request review feature in pull request add a way to notify specific reviewers to review like github , by add or delet a special type review . The acton is is similar to Assign , so many code reuse the function and items of Assignee, but the meaning and result is different. The Permission style is is similar to github, that only writer can add a review request from Reviewers, but the poster can recall and remove a review request after a reviwer has revied even if he don't have Write Premission. only manager , the poster and reviewer of a request review can remove it. The reviewers can be requested to review contain all readers for private repo , for public, contain all writers and watchers. The offical Review Request will block merge if Reject can block it. an other change: add ui otify for Assignees. Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv> Signed-off-by: a1012112796 <1012112796@qq.com> * new change * add placeholder string * do some changes follow #10238 to add review requests num on lists also change icon for review requests to eye Co-authored-by: Lauris BH <lauris@nix.lv>mj
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
24 changed files with 714 additions and 67 deletions
-
3models/branches.go
-
2models/issue_comment.go
-
77models/notification.go
-
2models/notification_test.go
-
58models/repo.go
-
154models/review.go
-
3models/review_test.go
-
1modules/notification/base/notifier.go
-
4modules/notification/base/null.go
-
7modules/notification/mail/mail.go
-
7modules/notification/notification.go
-
35modules/notification/ui/ui.go
-
12options/locale/locale_en-US.ini
-
152routers/repo/issue.go
-
1routers/routes/routes.go
-
2routers/user/home.go
-
20services/issue/assignee.go
-
21templates/repo/issue/list.tmpl
-
21templates/repo/issue/milestone_issues.tmpl
-
22templates/repo/issue/view_content/comments.tmpl
-
22templates/repo/issue/view_content/pull.tmpl
-
91templates/repo/issue/view_content/sidebar.tmpl
-
21templates/user/dashboard/issues.tmpl
-
43web_src/js/index.js
Write
Preview
Loading…
Cancel
Save
Reference in new issue