Browse Source

Return 404 not 500 from API if team does not exist (#13118)

If team does not exist expect ErrTeamNotExist not ErrUserNotEXist

Fix #11336

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
mj-v1.14.3
zeripath 2 years ago
committed by GitHub
parent
commit
f2858600af
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      routers/api/v1/api.go

2
routers/api/v1/api.go

@ -404,7 +404,7 @@ func orgAssignment(args ...bool) macaron.Handler {
if assignTeam {
ctx.Org.Team, err = models.GetTeamByID(ctx.ParamsInt64(":teamid"))
if err != nil {
if models.IsErrUserNotExist(err) {
if models.IsErrTeamNotExist(err) {
ctx.NotFound()
} else {
ctx.Error(http.StatusInternalServerError, "GetTeamById", err)

Loading…
Cancel
Save