From fb57aa8c94b1cf0190489a840ab8d64468772163 Mon Sep 17 00:00:00 2001
From: Pierre-Louis Guhur <pierre-louis.guhur@laposte.net>
Date: Thu, 1 Dec 2022 07:50:03 +0100
Subject: [PATCH] fix: cleanup election ref

---
 components/WaitingBallot.tsx         | 19 ++++++++++++-------
 components/WaitingElection.tsx       |  8 ++++----
 components/admin/AdminModalEmail.tsx |  6 +++---
 components/admin/ConfirmField.tsx    |  5 ++---
 pages/vote/[pid]/[[...tid]].tsx      | 12 ++++++------
 services/routes.ts                   | 17 +++++++++--------
 services/utils.ts                    |  7 +++++++
 7 files changed, 43 insertions(+), 31 deletions(-)

diff --git a/components/WaitingBallot.tsx b/components/WaitingBallot.tsx
index 2f384ab..7e22859 100644
--- a/components/WaitingBallot.tsx
+++ b/components/WaitingBallot.tsx
@@ -11,11 +11,14 @@ import ErrorMessage from '@components/Error';
 import AdminModalEmail from '@components/admin/AdminModalEmail';
 import {BallotPayload, ErrorPayload} from '@services/api';
 import {useAppContext} from '@services/context';
-import {getUrlResults} from '@services/routes';
-import urne from '../public/urne.svg'
-import star from '../public/star.svg'
+import {displayRef} from '@services/utils';
+import {RESULTS} from '@services/routes';
 import Logo from './Logo';
 import {FORM_FEEDBACK} from '@services/constants';
+import urne from '../public/urne.svg'
+import star from '../public/star.svg'
+import logo from '../public/logo-red-blue.svg'
+import Link from 'next/link';
 
 
 export interface WaitingBallotInterface {
@@ -32,9 +35,11 @@ const ButtonResults = ({election}) => {
 
   if (!election.hideResults || isEnded) {
     return (
-      <Button className="" icon={faArrowRight} position="right">
-        {t('vote.go-to-results')}
-      </Button>
+      <Link href={`${RESULTS}/${displayRef(election.ref)}`}>
+        <Button className="" icon={faArrowRight} position="right">
+          {t('vote.go-to-results')}
+        </Button>
+      </Link>
     )
   } else {
     return null;
@@ -66,7 +71,7 @@ const SupportBetterVote = () => {
       <div>
         <div className="d-flex mb-2 align-items-center justify-content-between">
           <h5>{t('vote.support-better-vote')}</h5>
-          <Logo title={false} />
+          <Logo src={logo} title={false} />
         </div>
         <p>{t('vote.support-desc')}</p>
       </div>
diff --git a/components/WaitingElection.tsx b/components/WaitingElection.tsx
index a03130d..61470e2 100644
--- a/components/WaitingElection.tsx
+++ b/components/WaitingElection.tsx
@@ -34,8 +34,8 @@ const InfoElection = ({election, error, display}: InfoElectionInterface) => {
 
   if (!election) return null;
 
-  const urlVote = getUrlVote(election.id)
-  const urlResults = getUrlResults(election.id)
+  const urlVote = getUrlVote(election.ref)
+  const urlResults = getUrlResults(election.ref)
 
   return (
     <div style={{
@@ -47,7 +47,7 @@ const InfoElection = ({election, error, display}: InfoElectionInterface) => {
       {error && error.detail ?
         <ErrorMessage msg={error.detail[0].msg} /> : null}
 
-      {election && election.id ?
+      {election && election.ref ?
         <>
           <h4 className="text-center">
             {t('admin.success-election')}
@@ -83,7 +83,7 @@ const InfoElection = ({election, error, display}: InfoElectionInterface) => {
           <AdminModalEmail
             toggle={toggleModal}
             isOpen={modal}
-            electionId={election.id}
+            electionRef={election.ref}
             adminToken={election.admin}
           />
         </> : null}
diff --git a/components/admin/AdminModalEmail.tsx b/components/admin/AdminModalEmail.tsx
index 103256f..36697f8 100644
--- a/components/admin/AdminModalEmail.tsx
+++ b/components/admin/AdminModalEmail.tsx
@@ -12,16 +12,16 @@ import {useElection} from '@services/ElectionContext';
 interface AdminModalEmailInterface {
   isOpen: boolean;
   toggle: () => void;
-  electionId: number | null;
+  electionRef: string | null;
   adminToken: string | null;
 }
 
-const AdminModalEmail = ({isOpen, toggle, electionId, adminToken}: AdminModalEmailInterface) => {
+const AdminModalEmail = ({isOpen, toggle, electionRef, adminToken}: AdminModalEmailInterface) => {
   const {t} = useTranslation();
   const [email, setEmail] = useState(undefined);
   const election = useElection();
 
-  const adminUrl = electionId && adminToken ? getUrlAdmin(electionId.toString(), adminToken) : null;
+  const adminUrl = electionRef && adminToken ? getUrlAdmin(electionRef, adminToken) : null;
 
   const handleEmail = (e) => {
     setEmail(e.target.value);
diff --git a/components/admin/ConfirmField.tsx b/components/admin/ConfirmField.tsx
index a22c06e..26582a5 100644
--- a/components/admin/ConfirmField.tsx
+++ b/components/admin/ConfirmField.tsx
@@ -88,14 +88,13 @@ const submitElection = (
     election.restricted,
     election.randomOrder,
     async (payload: ElectionPayload) => {
-      const id = payload.id;
       const tokens = payload.invites;
       if (typeof election.emails !== 'undefined' && election.emails.length > 0) {
         if (typeof payload.invites === 'undefined' || payload.invites.length !== election.emails.length) {
           throw Error('Can not send invite emails');
         }
-        const urlVotes = payload.invites.map((token: string) => getUrlVote(id.toString(), token));
-        const urlResult = getUrlResults(id.toString());
+        const urlVotes = payload.invites.map((token: string) => getUrlVote(payload.ref, token));
+        const urlResult = getUrlResults(electionRef);
         await sendInviteMails(
           election.emails,
           election.name,
diff --git a/pages/vote/[pid]/[[...tid]].tsx b/pages/vote/[pid]/[[...tid]].tsx
index dd0be68..e1f5ea9 100644
--- a/pages/vote/[pid]/[[...tid]].tsx
+++ b/pages/vote/[pid]/[[...tid]].tsx
@@ -21,19 +21,19 @@ export async function getServerSideProps({query: {pid, tid}, locale}) {
   return {
     props: {
       ...(await serverSideTranslations(locale, ['resource'])),
-      electionId: pid,
+      electionRef: pid,
       token: tid || null,
     },
   }
 }
 
 interface VoteInterface {
-  electionId: string;
+  electionRef: string;
   token?: string;
 }
 
 
-const GoToBallotConfirm = ({electionId, token}) => {
+const GoToBallotConfirm = ({electionRef, token}) => {
 
   const {t} = useTranslation();
 
@@ -52,7 +52,7 @@ const GoToBallotConfirm = ({electionId, token}) => {
           </Row>
 
           <Row>
-            <Link href={`${BALLOT}/${electionId}/${token ? token : ""}`}>
+            <Link href={`${BALLOT}/${electionRef}/${token ? token : ""}`}>
               <Button
                 color="secondary"
                 outline={true}
@@ -79,12 +79,12 @@ const GoToBallotConfirm = ({electionId, token}) => {
   )
 }
 
-const Vote = ({electionId, token}: VoteInterface) => {
+const Vote = ({electionRef, token}: VoteInterface) => {
 
   return (
     <>
       <section>
-        <GoToBallotConfirm electionId={electionId} token={token} />
+        <GoToBallotConfirm electionRef={electionRef} token={token} />
       </section>
       <section className="sectionTwoHome">
         <AdvantagesRow />
diff --git a/services/routes.ts b/services/routes.ts
index 72b6659..586c222 100644
--- a/services/routes.ts
+++ b/services/routes.ts
@@ -1,7 +1,7 @@
 /**
  * This file provides the paths to the pages
  */
-import {getWindowUrl} from './utils';
+import {getWindowUrl, displayRef} from './utils';
 
 
 export const CREATE_ELECTION = '/admin/new/';
@@ -10,19 +10,20 @@ export const ENDED_VOTE = '/ballot/end';
 export const VOTE = '/vote/';
 export const RESULTS = '/result/';
 
-export const getUrlVote = (electionId: string | number, token?: string): URL => {
+export const getUrlVote = (electionRef: string | number, token?: string):  URL => {
   const origin = getWindowUrl();
   if (token)
-    return new URL(`/${VOTE}/${electionId}/${token}`, origin);
-  return new URL(`/${VOTE}/${electionId}`, origin);
+    return new URL(`/${VOTE}/${displayRef(electionRef)}/${token}`, origin);
+  return new URL(`/${VOTE}/${displayRef(electionRef)}`, origin);
 }
 
-export const getUrlResults = (electionId: string | number): URL => {
+export const getUrlResults = (electionRef: string | number): URL => {
   const origin = getWindowUrl();
-  return new URL(`/${RESULTS}/${electionId}`, origin);
+  return new URL(`/${RESULTS}/${displayRef(electionRef)}`, origin);
 }
 
-export const getUrlAdmin = (electionId: string | number, adminToken: string): URL => {
+export const getUrlAdmin = (electionRef: string | number, adminToken: string): URL => {
   const origin = getWindowUrl();
-  return new URL(`/admin/${electionId}?t=${adminToken}`, origin);
+  return new URL(`/admin/${displayRef(electionRef)}/${adminToken}`, origin);
 }
+
diff --git a/services/utils.ts b/services/utils.ts
index 9e9010a..94bdde5 100644
--- a/services/utils.ts
+++ b/services/utils.ts
@@ -24,3 +24,10 @@ export const getWindowUrl = (): string => {
     : 'http://localhost';
 }
 
+
+export const displayRef = (ref: string): string => {
+  if (ref.length !== 10) {
+    throw Error("Unexpected election ref");
+  }
+
+  return `${ref.substring(0, 3)}-${ref.substring(3, 6)}-${ref.substring(6)}`